1075/enhancement/Make col class with __getattr__ #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
approved these changes
Apr 27, 2025
|
I got it from polars, not clever on my part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1075
Rationale for this change
To improve ergonomics of the API by providing a quicker way of accessing columns using the
__getattr__method of classes. Using the__call__method, the original behavior is maintained, this is only additive.Now this is possible
What changes are included in this PR?
A new col.py file with the class. I removed the col and column function from
__init__and imported col and column from col.py. I added a test that duplicates another test but uses the new syntax.Are there any user-facing changes?
Only optional ones as mentioned above.
No breaking changes.